Skip to content

Adjust Windows-only logic in __init__.py #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 1, 2025
Merged

Adjust Windows-only logic in __init__.py #2553

merged 6 commits into from
Sep 1, 2025

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Aug 6, 2025 •
edited by antonwolfy
Loading

This PR suggests small changes to Windows-specific logic in __init__.py

hasattr(os, "add_dll_directory") is unnecessary after platform check and is removed, and sys.platform == "win32" is used which is more commonly seen in the ecosystem and avoids importing platform module

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_19 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Aug 6, 2025 •
edited
Loading

Coverage Status

coverage: 72.189% (-0.001%) from 72.19%
when pulling 1ee96f1 on adjust-windows-platform-check
into d975818 on master.

antonwolfy
antonwolfy approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Aug 6, 2025
@antonwolfy
Copy link
Contributor

Could you please add the PR to the changelog also?

@ndgrigorian
Copy link
Collaborator Author

Could you please add the PR to the changelog also?

done, it's been added

@ndgrigorian ndgrigorian requested a review from antonwolfy August 22, 2025 18:51
@antonwolfy antonwolfy merged commit 3c8ac08 into master Sep 1, 2025
76 of 86 checks passed
@antonwolfy antonwolfy deleted the adjust-windows-platform-check branch September 1, 2025 15:24
vlad-perevezentsev pushed a commit that referenced this pull request Sep 4, 2025
@ndgrigorian @vlad-perevezentsev
Adjust Windows-only logic in __init__.py (#2553)
84cd715 
This PR suggests small changes to Windows-specific logic in
`__init__.py`

`hasattr(os, "add_dll_directory")` is unnecessary after platform check
and is removed, and `sys.platform == "win32"` is used which is more
commonly seen in the ecosystem and avoids importing `platform` module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana

Assignees

@ndgrigorian ndgrigorian

Labels

None yet

Projects

None yet

Milestone

0.19.0 release

Development

Successfully merging this pull request may close these issues.

4 participants

@ndgrigorian @coveralls @antonwolfy @vlad-perevezentsev